Fallback message if unable to get git revision #141
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix http://build.ros.org/job/Nbin_uF64__ypspur__ubuntu_focal_amd64__binary/5/ which is appears to be the cause of a failure to build packages for
ros-noetic-ypspur
andros-noetic-ypspur-ros
. I have not tested this change locally, but some fix needs to be released to ROS Noetic so these packages are still available in the next Noetic sync. Please take a look as soon as possible, ideally before tomorrow.This patch:
-C <path>
when callinggit rev-parse
It looks like the generated
config.h
has a value forPROJECT_VERSION
that contains a newline.Resulting in this compile error.
I don't know what changed since there's been no yp-spur release since the last successful build. Maybe there's a newer version of
git
in Ubuntu Focal that has this new error message?